Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const lvalue ref to editor/* container parameters #88368

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Muller-Castro
Copy link
Contributor

@Muller-Castro Muller-Castro commented Feb 15, 2024

Adds const lvalue reference to the core container types specified in the documentation that are declared in function parameters in editor/* files

initial: #51156
core/*: #86966
modules/*: #88915
platform/*: #88971
servers/*: #88972
scene/*: #88974
others: #88975

@Muller-Castro Muller-Castro requested review from a team as code owners February 15, 2024 16:29
@AThousandShips AThousandShips changed the title Add const lvalue ref to editor/* container parameters Add const lvalue ref to editor/* container parameters Feb 15, 2024
@AThousandShips AThousandShips modified the milestones: 4.4, 4.x Feb 15, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 27, 2024
@akien-mga akien-mga merged commit 2b7513a into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants