Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codium support to C# external editors #89051

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 1, 2024

Selecting the VS Code option will now work if Codium is installed, picking it as the last option after attempting to run VS Code.

Not tested on any OS, so please test on macOS and Windows or Linux before merging.

Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine. We could loop over a string[] { "com.microsoft.VSCode", "com.vscodium.codium" } instead of duplicating the whole block.
Would be nice if a Codium user could try it out, I'm not too keen on nuking my VSC setup to be able to test 😭.

Selecting the VS Code option will now work if Codium is installed,
picking it as the last option after attempting to run VS Code.
@Calinou Calinou force-pushed the csharp-vscode-add-codium-support branch from 99baabe to 9f2bd57 Compare November 1, 2024 23:00
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally tested. LGTM.

@paulloz paulloz modified the milestones: 4.x, 4.4 Nov 2, 2024
@Repiteo Repiteo merged commit 66fb0cd into godotengine:master Nov 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VSCodium to the list of external C# editors
3 participants