-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some invalid int
property ranges
#89566
Conversation
I think it would be useful. Exp was probably used in an attempt to have more control over the lower values (where particle count is WAY more noticeable). |
We can always add it back in if we improve that side, but ensuring it works correctly might be finicky, and might be buggy with integer values especially in the lower range (though I haven't tested it myself) So opening a separate PR and adding different cases that would benefit from |
Instead of removing it, which does not change anything, you could put a FIXME comment. |
Sure can do that instead, this does do one thing though: Discourage others adding this to their code thinking it will work |
f9f9324
to
5a47711
Compare
With just a quick check, without doing any deeper reworking, adding support for So I think the better solution is simply to remove it, I don't see the usefulness of it, but I'll leave it as a note for now but I'd say to just remove it is the better solution, even with the slider exposed by using a smaller than 1 step it's still very clumsy to edit like that, so I don't see the usefulness at al |
exp range for particles amount was added back in dfd1331. idk if it was better back then, but I guess it doesn't make much sense anymore. |
As you can see from the code the integer one didn't support exp then either so it seems to always have been dead code It even uses the |
5a47711
to
943a4f5
Compare
943a4f5
to
c6acf42
Compare
c6acf42
to
bcccef3
Compare
bcccef3
to
093f6ca
Compare
093f6ca
to
f706198
Compare
f706198
to
843c63a
Compare
* `HeightMapShape3D` had ranges configured for `float` instead of `int` * Particles had `amount` that used `exp` which is not supported, added note
843c63a
to
f6ea6cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the particles emitter's amount
property makes a really strong case for actually supporting exp
for integers. Particle count matters more at lower values where granular control is more desirable. That is to say, the difference between 1000
and 2000
particles is not as stark as 10
and 20
.
However, that's unrelated. Beyond the comment, the PR itself fixes an obvious oversight in HeightMapShape3D.
Thanks! |
Thank you! |
HeightMapShape3D
had ranges configured forfloat
instead ofint
amount
that usedexp
which is not supported, added a noteThe
amount
case could be fixed by adding support for this toEditorPropertyInteger
but unsure how useful that would be generally, so just fixing it here