Add colored transparent shadows to LightmapGI #90132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #100961 Thank you very much for your work and for being the main force behind getting transparency working in the lightmapper. While Geometror's PRs ultimately superseded yours, we are still very thankful for your effort and recognize that this achievement belongs to both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #90109 (note: this PR already include the parent commit, once the parent is merged I'll remove it)
This adds support for colored (static) shadows for LightmapGI.
The transparency come from the pull dependency.
Screenshots
note: there would be a greater control (and better realism) if I could use the transmission from the material but I'm not sure on how to do that for now so I'll settle on something simple.