Optimize some parts of NavMap::sync
#90182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few optimizations I've done while investigating navigation on a large procedural streaming terrain.
HashMap
lookupsVector<T>
because they only ever have up to 2 elementspush_back
andHashMap
re-hashsNote: I saw that in
Find the compatible near edges
there is a double for loop, which seems to pretty much iterate every possible pair of free edges. This will iterate each pair twice, (A, B) and (B, A). Unless I'm missing something, the inner loop could usefor (unsigned int j = i + 1; j < free_edges.size(); j++) {
so each pair only has to be iterated once. But I haven't done that change because I'm not sure if the current loop is actually intented.