-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Node3D.scale()
as scale_object()
#90321
base: master
Are you sure you want to change the base?
Conversation
scale
method to the editorNode3D.scale()
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't valid, you can't expose scale
because there's already the scale
property
Can this be exposed under another name? |
Sure, unsure what name would be appropriate though Also unsure if we should have a whole three different scaling methods, we already have |
If I haven't tested it wrong, this method scales along the local axes of the parent node so it's different from the other two. |
Right, it's different, I'm saying it'll be confusing with three different ones |
It'd pair with rotation methods as there are 3 different types In the end this is just a shortcut for |
Sorry I'm confused. Should I close this PR or change the exposed name? |
Go ahead and change it and we'll see what name is agreed on |
b23e494
to
ad57b44
Compare
ad57b44
to
90b377e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We resolved the name overlap so I think the scale_object gdscript expose is fine.
90b377e
to
f2f382c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the details for this one in #87440
Commit & PR could use a better title since the name has changed |
Such as "Expose Node3D.scale() as scale_object()" ? |
Yes, sounds fine enough |
f2f382c
to
367aa10
Compare
Node3D.scale()
methodNode3D.scale()
as scale_object()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are consistent and just fine, if this review is of any additional support.
Expose
Node3D.scale()
to the editor side asscale_object()
.