Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS export] Detect embedded helper executables using MachO header. #90428

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 9, 2024

Embedded helper executables in the sandboxed app require special entitlements and seems to need identifier set to apply main provisioning profile.

Previously, only explicitly specified executables were using special entitlements, this PR additionally checks headers of the embedded shared objects to detect executables that were added by plugins or as part of GDExtension.

Might fix #90397 (.NET exports include cratedump executable).

@bruvzg bruvzg added this to the 4.3 milestone Apr 9, 2024
@bruvzg bruvzg marked this pull request as ready for review April 22, 2024 07:06
@bruvzg bruvzg requested a review from a team as a code owner April 22, 2024 07:06
@akien-mga akien-mga merged commit 339cb0e into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot 4.2.1.mono: "Game.dylib" can't be opened because Apple cannot check it for malicious software
2 participants