Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Standardize permission descriptions, add urls, remove deprecated tag from non-deprecated permission #90546

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Android: Standardize permission descriptions, add urls, remove deprecated tag from non-deprecated permission #90546

merged 1 commit into from
Apr 12, 2024

Conversation

melquiadess
Copy link
Contributor

This PR:

@melquiadess melquiadess requested a review from a team as a code owner April 11, 2024 20:52
m4gr3d
m4gr3d approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@melquiadess melquiadess changed the title [Android] Standardize permission descriptions, add urls, remove deprecated tag from non-deprecated permission Android: Standardize permission descriptions, add urls, remove deprecated tag from non-deprecated permission Apr 11, 2024
@melquiadess
Copy link
Contributor Author

The macOS Editor unit tests failed, but looks like for an unrelated reason. Is it a genuine fail, or a fluke?

@melquiadess
Copy link
Contributor Author

The macOS Editor unit tests failed, but looks like for an unrelated reason. Is it a genuine fail, or a fluke?

Apparently a random unit test fail

@akien-mga akien-mga added this to the 4.3 milestone Apr 12, 2024
@akien-mga akien-mga merged commit 91aca6e into godotengine:master Apr 12, 2024
16 checks passed
@melquiadess melquiadess mentioned this pull request Apr 12, 2024
Merged
@akien-mga
Copy link
Member

Thanks!

@melquiadess melquiadess deleted the add-urls-and-standardize-descriptions branch April 12, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@melquiadess @akien-mga @m4gr3d