-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust orthographic camera gizmo with respect to keep_aspect
setting
#90690
Conversation
I see, thanks for your help! It should feel more correct now. |
5681f37
to
e6c14c1
Compare
e6c14c1
to
b97d995
Compare
Works correctly now as far as I can tell! Just waiting for a review now. Thanks again. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Both Keep Height and Keep Width orthgographic gizmos render correctly now, even if the base aspect ratio is changed in the project settings (when changing the window width/height project settings).
Code looks good to me.
Before | After |
---|---|
![]() |
![]() |
Example of the sizes being correct now:
keep_aspect
setting
Thanks! |
Fixes #90589