-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose several resource/resource-saver functions #90969
Expose several resource/resource-saver functions #90969
Conversation
4c6e514
to
9c65962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one issue to fix, but I'd like to see more justification for why these methods should be exposed.
There's no linked proposal, nor any explanation about what you need those methods for.
9c65962
to
f143400
Compare
Hi @akien-mga, exposing a number of these The goal of exposing these is so that if a GDExtension implements a custom resource with custom loader/saver format impls that those implementations can reuse the existing ResourceCache and other facilities within the engine and only focus on supplying the bare implementation needed for the custom resource, loader, and saver wrappers. In short, this allows a GDExtension implementation of a custom resource loader/saver to be able to work similarly to C++ modules that were to implement the loader/saver interface. |
f143400
to
bc3dcf3
Compare
@akien-mga applied your suggestions. |
Thanks! |
Exposes several methods for GDExtension and script languages related to
Resource
,ResourceUID
, andResourceSaver
.Bugsquad edit: The methods are Resource
get_id_for_path
,is_built_in
,reset_state
,set_id_for_path
,set_path_cache
, and ResourceSaverget_resource_id_for_path
.