Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node.duplicate() crash when duplicating a node that cannot be instantiated. #90992

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix Node.duplicate() crash when duplicating a node that cannot be instantiated. #90992

merged 1 commit into from
Aug 19, 2024

Conversation

radiantgurl
Copy link
Contributor

closes #90991

@radiantgurl radiantgurl requested a review from a team as a code owner April 21, 2024 22:00
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 22, 2024
KoBeWi
KoBeWi reviewed Jul 30, 2024
View reviewed changes
@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 30, 2024
@radiantgurl radiantgurl force-pushed the fix_node_duplicate branch 2 times, most recently from d73ecf3 to d4bddc5 Compare August 2, 2024 13:23
@radiantgurl radiantgurl requested review from a team as code owners August 2, 2024 13:23
@AThousandShips AThousandShips removed request for a team August 2, 2024 13:40
@AThousandShips
Copy link
Member

Your rebase went wrong and it added you as owner for other commits

@radiantgurl
Copy link
Contributor Author

radiantgurl commented Aug 2, 2024 •
edited
Loading

Your rebase went wrong and it added you as owner for other commits

Yeah, it was my own fork's master branch. I used git merge on it, and it resulted in that happening.
I used git rebase on the broken branch and resulted in that.
Now i used git reset --hard mainstream/master to properly sync my master branch so it wont happen again.

@AThousandShips AThousandShips removed request for a team August 2, 2024 14:18
@akien-mga akien-mga changed the title Fix node.duplicate() crash when duplicating a node that cannot be instantiated. Fix Node.duplicate() crash when duplicating a node that cannot be instantiated. Aug 19, 2024
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 19, 2024
@akien-mga akien-mga merged commit 6d22b80 into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@radiantgurl radiantgurl deleted the fix_node_duplicate branch September 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Crash when duplicating an editor internal node
4 participants
@radiantgurl @AThousandShips @akien-mga @KoBeWi