Change param name of AStar's _estimate_cost method
#92123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Jul 5, 2024
raulsntos
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Changes to parameter names break source compatibility in C# because the call-site could be using named parameters, but since these are virtual methods and aren't meant to be called from scripting, then I don't think this matters.
So regarding C# compat, I think the change is fine 👍
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A* classes all have two similar cost functions:
_estimate_cost(from, to)_compute_cost(from, to)It's easy to misunderstand that their second parameters are the same. But in fact,
_estimate_cost()receives the end point of the search query, while_compute_cost()receives a connected (neighbour) point.