Add MagnifyGesture to Advanced Import dialog zooming

[paddy-exe]

This adds the ability for Macbooks and other devices that use the magnifying gesture to zoom in the advanced import dialog.

Showcase

Bildschirmaufnahme.2024-05-22.um.04.18.43.mov

[fire]

It looks ok; I'm not too fond of magical constants, though, especially in UI.

Can you get the factor to be 0, triggering a divide by 0?

[paddy-exe]

It looks ok; I'm not too fond of magical constants, though, especially in UI.

We have the same constants for the MouseButton Scrolling (just above my changes):

Ref<InputEventMouseButton> mb = p_input;
if (mb.is_valid() && mb->get_button_index() == MouseButton::WHEEL_DOWN) {
  (*zoom) *= 1.1;
  if ((*zoom) > 10.0) {
    (*zoom) = 10.0;
  }
  _update_camera();
}
if (mb.is_valid() && mb->get_button_index() == MouseButton::WHEEL_UP) {
  (*zoom) /= 1.1;
  if ((*zoom) < 0.1) {
    (*zoom) = 0.1;
  }
  _update_camera();
}

Can you get the factor to be 0, triggering a divide by 0?

No. I have tested it myself.

[lyuma]

I would feel safer about this if there is either documentation proving it won't be 0, or some check to prevent division by 0.

other than that, @fire 's comment sounds like an approval, and I think it seems good.

[paddy-exe]

I would feel safer about this if there is either documentation proving it won't be 0, or some check to prevent division by 0.

other than that, @fire 's comment sounds like an approval, and I think it seems good.

@bruvzg Could you give your insight into this if InputEventMagnifyGesture get_factor can reach zero? If it actually can I would add the extra check.

[bruvzg]

Could you give your insight into this if InputEventMagnifyGesture get_factor can reach zero?

It should not happen with real events. But nothing in the event code prevents it from being zero (you can create an event with zero factor from a script and feed it to the Input.parse_input_event()), so having a check is safer.

[paddy-exe]

Check is implemented and PR rebased.

[Repiteo]

Thanks!