Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement drag-and-drop logic for previewing themes #92435

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Implement drag-and-drop logic for previewing themes #92435

merged 1 commit into from
Jan 10, 2025
+53 −0

Conversation

Jabberdrake
Copy link
Contributor

Dragging valid theme files (.tscn files with a Control node at the top) from the filesystem region over to the ThemeEditor will preview the theme in question in a new preview tab

Co-authored-by: Sofia Paiva sofia.paiva@tecnico.ulisboa.pt

@AThousandShips AThousandShips changed the title Implemented drag-and-drop logic for previewing themes Implement drag-and-drop logic for previewing themes May 27, 2024
@AThousandShips AThousandShips added this to the 4.x milestone May 27, 2024
@AThousandShips AThousandShips requested review from a team May 27, 2024 15:49
AThousandShips
AThousandShips reviewed Jun 2, 2024
View reviewed changes
KoBeWi
KoBeWi approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs some work, but the feature is fine overall.

@Jabberdrake
Copy link
Contributor Author

Apologies for the delays ;-;

Thank you all for the kind feedback, I believe I've fixed everything (assuming these checks all pass)!

@AThousandShips
Copy link
Member

Please squash your commits into one, see here

@Jabberdrake
Copy link
Contributor Author

Heya, is there anything else I need to do?

@akien-mga
Copy link
Member

Heya, is there anything else I need to do?

Not for now, it seems good to go. But we are in feature freeze for 4.3 so this is waiting for the 4.3 release to be published, before it can be merged for 4.4-dev.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jun 25, 2024
@arkology
Copy link
Contributor

Is there something that could be done to not miss 4.4dev window and not to wait for 4.5? :)

@KoBeWi
Copy link
Member

KoBeWi commented Jan 10, 2025

I added it to merge queue, so it should be merged for the upcoming beta1.

@Jabberdrake @sofia285 @akien-mga
Implemented drag-and-drop logic for previewing themes
3a6bfcb 
Dragging valid theme files (.tscn files with a Control node at the top)
from the filesystem region over to the ThemeEditor will preview the
theme in question in a new preview tab

Co-authored-by: Sofia Paiva <sofia.paiva@tecnico.ulisboa.pt>
@akien-mga
Copy link
Member

I rebased the PR to make sure it still compiles fine before merging, as the last update was many months ago.

Apologies this went under the radar until now, and thanks @arkology for digging this up so it doesn't miss the 4.4 merge window.

@akien-mga akien-mga merged commit a822080 into godotengine:master Jan 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement feature proposal topic:editor topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Jabberdrake @AThousandShips @akien-mga @arkology @KoBeWi