Prevent connect scroll_to_paragraph multiple times to class_desc
#92454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maran23
reviewed
May 28, 2024
| @@ -2340,7 +2340,11 @@ void EditorHelp::_help_callback(const String &p_topic) { | |||
|
|
|||
| if (class_desc->is_ready()) { | |||
| // call_deferred() is not enough. | |||
| if (class_desc->is_connected(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph))) { | |||
| class_desc->disconnect(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph)); | |||
There was a problem hiding this comment.
I wonder if we really need to disconnect and reconnect again? Or maybe we can just do
if !connected -> connect
There was a problem hiding this comment.
Yes, checking !is_connected is how it's done usually.
There was a problem hiding this comment.
If the line is not changed during multiple connect, then yes. I will take a look more closely.
Update: It controls which line to scroll to, IMHO it should favor the latter one, so disconnect and connect again with new line seems more reasonable.
There was a problem hiding this comment.
I missed the argument binding, indeed. Makes sense, then.
akien-mga
reviewed
May 28, 2024
jsjtxietian
force-pushed
the
multi-connect
branch
from
64b3f75 to
b33811d
Compare
akien-mga
approved these changes
May 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92405