GDScript: Remove RENAMED_IN_GODOT_4_HINT from GDScriptWarning::Code enum
#92526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 29, 2024
akien-mga
reviewed
May 29, 2024
dalexeev
force-pushed
the
gds-remove-renamed-hint-from-warning-enum
branch
from
e74eac6 to
cd918ff
Compare
akien-mga
approved these changes
Jan 9, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of
RENAMED_IN_GODOT_4_HINTin theGDScriptWarning::Codeenum means that a warning with codeRENAMED_IN_GODOT_4_HINTexists. However, it doesn't actually exist! A warning with this code is never produced.This option was mistakenly implemented as a warning, even though there are other checkboxes implemented as normal project settings. It also added hardcode in several places.
This PR fixes the above. This does not break compatibility, but there are two minor changes: the checkbox is moved up and the default value of the setting changes from
1totrue(which is correct since the type isbool).This PR also removes deprecated warnings from autocompletion, since they are never produced.