Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing check to avoid passing handled input event to collision object 3d. #92536

Merged

Conversation

Daylily-Zeleen
Copy link
Contributor

Fix get_tree().root.set_input_as_handled() can't blocking event passing to input_event of CollisionObject3D.


Here is MRP:
MRP.zip

@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner May 30, 2024 08:27
@Chaosus Chaosus added this to the 4.3 milestone May 30, 2024
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/fix_3d_input_event branch 2 times, most recently from 69eeca6 to 63a1a1e Compare May 30, 2024 09:20
Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can only check for is_input_handled() once before the 3D physics picking logic instead. (After the #ifndef on line 885.)

@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/fix_3d_input_event branch 6 times, most recently from d25d526 to 3066ff2 Compare June 4, 2024 06:41
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/fix_3d_input_event branch from 3066ff2 to d87482d Compare July 23, 2024 08:53
@Sauermann Sauermann self-requested a review July 24, 2024 23:13
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/fix_3d_input_event branch from d87482d to f90f663 Compare July 27, 2024 06:59
@Sauermann Sauermann added enhancement and removed bug labels Jul 27, 2024
@Sauermann Sauermann modified the milestones: 4.3, 4.4 Jul 27, 2024
@akien-mga akien-mga merged commit f565996 into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/fix_3d_input_event branch August 31, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants