Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringName: operator== compares in-place #92570

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

rune-scape
Copy link
Contributor

avoids copying internal String of the StringName when comparing
related: #70096

@rune-scape rune-scape requested a review from a team as a code owner May 30, 2024 21:05
@rune-scape rune-scape force-pushed the rune-stringname-bits branch 2 times, most recently from 77b5ca1 to 9183cab Compare May 30, 2024 22:56
@AThousandShips AThousandShips added this to the 4.x milestone May 31, 2024
@rune-scape rune-scape force-pushed the rune-stringname-bits branch from 9183cab to 0d22c9d Compare August 28, 2024 19:39
@dalexeev dalexeev modified the milestones: 4.x, 4.4 Aug 28, 2024
@rune-scape rune-scape force-pushed the rune-stringname-bits branch from 0d22c9d to c80bf67 Compare August 28, 2024 20:27
@akien-mga akien-mga changed the title StringName: operator== compares in-place StringName: operator== compares in-place Aug 29, 2024
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 69ca549 into godotengine:master Sep 4, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@rune-scape rune-scape deleted the rune-stringname-bits branch September 9, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants