Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Refine mypy integration #93052

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jun 11, 2024

Depends on: #93058

Updates mypy from 0.971 to 1.10.0, the latest version at time of writing. With this comes a few changes:

  • pyproject.toml mypy section is now sorted alphabetically, excluding the last two rules.
  • Added scripts_are_modules, which is already passed in the pre-commit & properly applies the aforementioned exclusion.
  • Added tokenize-rt dependency to hook as recommended by the repo's readme.
  • Added python_version, set to the lowest possible value supported (3.8).
  • Fixed three warnings in files caused by making typed declarations in untyped definitions.

@Repiteo Repiteo added this to the 4.x milestone Jun 11, 2024
@Repiteo Repiteo requested review from a team as code owners June 11, 2024 19:02
@Repiteo Repiteo removed request for a team June 11, 2024 19:02
@Repiteo
Copy link
Contributor Author

Repiteo commented Jun 11, 2024

Converting to draft now that #92264 is superseded; will repurpose to not exclude SCons files

@Repiteo Repiteo marked this pull request as draft June 11, 2024 20:43
@Repiteo Repiteo force-pushed the ci/mypy-adjustments branch from e63c730 to 33ef80d Compare June 16, 2024 14:45
@Repiteo
Copy link
Contributor Author

Repiteo commented Jun 16, 2024

Now explicitly depends on #93058, as that takes care of the Scons file errors; keeping as a draft until it's merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant