-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationPolygon: Implement get
/set_polygon
fast paths.
#93171
Merged
akien-mga
merged 1 commit into
godotengine:master
from
libklein:implement-set-get-polygons
Aug 16, 2024
Merged
NavigationPolygon: Implement get
/set_polygon
fast paths.
#93171
akien-mga
merged 1 commit into
godotengine:master
from
libklein:implement-set-get-polygons
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
362a265
to
fca467d
Compare
smix8
approved these changes
Jun 14, 2024
fca467d
to
bc48650
Compare
788ad1e
to
9420f1d
Compare
10e2af5
to
cd453bd
Compare
smix8
approved these changes
Jun 16, 2024
get
/set_polygon
fast paths.
Needs both a rebase for 4.4 and the newer thread locks added to the functions. |
cd453bd
to
fbafddc
Compare
Rebased onto the latest master:
|
smix8
requested changes
Aug 16, 2024
smix8
approved these changes
Aug 16, 2024
Thank! Looks fine. I dont have any objection against the overload, that at least makes it clear that this function should never get exposed by accident. |
Looks good! Could you squash the commits? See PR workflow for instructions. |
53d5b05
to
63126a4
Compare
63126a4
to
a1fe6ff
Compare
Thanks! |
Thank you! Is there any other issue I could assist with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR #92955. This PR implements the changes outlined in #92955 (comment).
As a first step, it implements fast-path
get/set_polygons
andget/set_outlines
functions, updatingNavMeshGenerator2D
accordingly. Implementedget/set_polygons
forNavigationMesh
as well, replacingadd_polygon
whenever a direct update was preferable.