-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a post-process shader template for CompositorEffect #93236
Conversation
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_shader.gd
Outdated
Show resolved
Hide resolved
e9ae7dd
to
571ba3d
Compare
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
e90fab0
to
81fe737
Compare
@dalexeev, @AThousandShips Please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on style
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
81fe737
to
ad0bc49
Compare
76131d7
to
8ffb644
Compare
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
0332673
to
9bc10a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GDScript code style looks good to me.
9bc10a0
to
3d41679
Compare
modules/gdscript/editor/script_templates/CompositorEffect/post_process_effect.gd
Outdated
Show resolved
Hide resolved
3d41679
to
fb20250
Compare
7ed6ae2
to
e22608f
Compare
After some thinking, I decided to divide it to two templates: one for simple |
a1c6aa6
to
4b559d7
Compare
85b3b22
to
dd70fca
Compare
That's because it only shows Node-based classes, and |
dd70fca
to
60a6161
Compare
Ah, thank you for checking, I forgot to check it with enabled type hints, my fault.. Fixed |
I'm personally not a big fan of this. CompositorEffects in its current form was always meant as a foundation that could be used by experienced users, ontop of which things could be build that hide the complexity (but also limit its functionality to specific use cases). For the use case here I made the shader example just as that, an example that shows how this could be used but which would need to be further worked out to become a good base. To be exact, I raised this proposal for a much better alternative some months ago: godotengine/godot-proposals#7849 The biggest issue that still needs to be worked out for that however is proper support for chaining effects where effects can read from the color buffer and write into a pong buffer, and visa versa. |
Alright, if it's not desired, then closed. |
I guess this should ease up the creation of
CompositorEffect
(code borrowed from https://docs.godotengine.org/en/latest/tutorials/rendering/compositor.html).