Fix super call in various get_configuration_warnings methods
#93353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:core
cherrypick:4.2
AThousandShips
commented
Jun 19, 2024
AThousandShips
added
the
cherrypick:4.3
AThousandShips
force-pushed
the
config_warning_fix
branch
from
e540fd7 to
bb5651c
Compare
AThousandShips
force-pushed
the
config_warning_fix
branch
from
bb5651c to
9dc2313
Compare
KoBeWi
approved these changes
Sep 6, 2024
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
This was referenced Nov 8, 2024
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered one of these while working on #93351 and decided to make further fixes
If any of these are intentional I'll restore them and add a comment to that effect, but assuming since no comment was added here that this was not intended to work around any inheritance
I haven't noticed any issues from these but haven't tested it myself, but it will ignore the intervening classes, which might ignore stuff we want