Forbid calling of derivative functions in incorrect functions #93358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
5 times, most recently
from
d3d574c to
76d5644
Compare
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
12 times, most recently
from
daccbcd to
7ca1e01
Compare
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
7 times, most recently
from
8e04a9d to
8933f7e
Compare
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
2 times, most recently
from
ea424fd to
e442f43
Compare
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
4 times, most recently
from
e1ef3ac to
f8fb3a9
Compare
Calinou
approved these changes
Jun 21, 2024
Calinou
reviewed
Jun 21, 2024
Calinou
reviewed
Jun 21, 2024
Calinou
reviewed
Jun 21, 2024
Chaosus
force-pushed
the
shader_forbid_derivative_usage
branch
from
f8fb3a9 to
ae95531
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76155
Compared to #83897 this code will recursively check the functions, and if it contains any derivative function and being called by
vertexprocessor - it will correctly emit error.