Remove code duplication in Button #93389
Open
+25
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Jun 20, 2024
| theme_cache.style_margin_right = 0; | ||
| theme_cache.style_margin_top = 0; | ||
| theme_cache.style_margin_bottom = 0; | ||
|
|
||
| const bool rtl = is_layout_rtl(); | ||
| if (rtl && has_theme_stylebox(SNAME("normal_mirrored"))) { |
There was a problem hiding this comment.
Since we have theme cache here I wonder if we can replace this check with a check against:
Suggested change
| if (rtl && has_theme_stylebox(SNAME("normal_mirrored"))) { | |
| if (rtl && theme_cache.normal_mirrored.is_valid()) { |
I'm not extremely well versed with the theme system but looking at the code it seems it should be equivalent
There was a problem hiding this comment.
Not sure about that, see #84944 (comment)
There was a problem hiding this comment.
Got it! Though I realized (hence unresolving) that if they aren't equivalent this code will segfault, so even if it's not a 100% drop in it does handle potential crashes, hasn't been a problem in the past though it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.