Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derivative functions to sky shader mode in visual shader #93399

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add derivative functions to sky shader mode in visual shader #93399

merged 1 commit into from
Jan 10, 2025

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 20, 2024

Since it's supported in text sky shaders.

@Chaosus Chaosus requested a review from a team as a code owner June 20, 2024 16:24
@Chaosus Chaosus added this to the 4.4 milestone Jun 20, 2024
paddy-exe
paddy-exe approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't tested it though.

@akien-mga
Copy link
Member

Might be worth rebasing before merge just to make sure this still compiles half a year later.

@Chaosus
Copy link
Member Author

Chaosus commented Jan 10, 2025

@akien-mga Done

@akien-mga akien-mga merged commit 138c2c8 into godotengine:master Jan 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_sky_derivative branch January 13, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaosus @akien-mga @paddy-exe