Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing audio bus button styles #93443

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add missing audio bus button styles #93443

merged 1 commit into from
Nov 6, 2024

Conversation

passivestar
Copy link
Contributor

These were missing hover-pressed and mirrored variations and were falling back to FlatButton styles

Before:

before.mp4

After:

after.mp4

@Calinou Calinou added this to the 4.3 milestone Jun 21, 2024
@AThousandShips AThousandShips requested a review from a team July 12, 2024 13:39
@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 31, 2024
@passivestar passivestar requested a review from a team as a code owner November 5, 2024 11:04
akien-mga
akien-mga approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and trivial enough.

@Repiteo Repiteo merged commit 3b708a4 into godotengine:master Nov 6, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 6, 2024

Thanks!

@passivestar passivestar deleted the audio-bus-buttons branch November 6, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:audio topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@passivestar @Repiteo @akien-mga @Calinou @KoBeWi