-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom compiler arguments in dotnet build #93539
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
fe7c8f2
to
31107b7
Compare
31107b7
to
59d1a68
Compare
One great addition here would be the ability to provide extra arguments in an export preset. It would help replace |
Oh yes. The current state of this draft only differentiates between publish (export) and in-editor. I haven't considered export presets because
These are not strong arguments and if I find time and feel charity-ish, I might find a solution for export template options. In the meantime, if anyone wants to expand on this draft, please let me know! One idea I have for working around such a user-friendly solution tho:
I have done something similar for the godot-git-plugin to avoid it being exported (godotengine/godot-git-plugin#77 (comment)). |
Exposes two new "advanced" project settings: - ProjectSettings/dotnet/build/custom_build_arguments, - ProjectSettings/dotnet/build/custom_publish_arguments The arguments provided will be appended to dotnet build <engine args> <user args>. The former will be appended when building in editor, the latter on exports. Because the arguments are appended, they override any engine provided arguments.
f807ef2
to
903d120
Compare
Proposal to Enable Custom Compiler Arguments in dotnet build
The What
This pull request allows users to pass additional compiler arguments to the
dotnet build
process to enhance flexibility and potentially reduce build times.This implementation is based on the proposal by @paulloz. It emerged after the rejection of my previous attempt to address build times, which rightly so got rejected after careful review by @raulsntos (see original proposal).
In Detail
Changes to Project Settings
Modifications to Build Process
Demonstration
The custom arguments are hidden by default and can be found under "Advanced settings" for Mono builds:
Both Build and Rebuild processes respect the custom compiler arguments: