Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more image types for some project settings #93746

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 29, 2024

I noticed some project settings for images (icon, cursor) are limited to only couple of extensions, for no reason. This PR adds some additional extensions.

When splash screen is loaded, only PNG image loader is available, so that setting is unchanged.

@KoBeWi KoBeWi added this to the 4.x milestone Jun 29, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner June 29, 2024 15:51
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Particularly nice for application/config/icon. Looks fine.

We should look into another way to go about this, perhaps. It can be difficult to keep track of all of these extensions if more are added.
Simpler way out, make them share the same constant String. Alternatively, the way the Image resource is imported into the project should matter, not its extension.

@AdriaandeJongh
Copy link
Contributor

Does setting icons to these formats work for every export platform, or is there a conversion to a format that works for the selected platform during export? Because i'm fairly certain setting the icon of an iOS app to .bmp doesn't fly ;)

@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 30, 2024

The icon is loaded as Image before its set, so the format does not matter. Also this setting is used only for the window icon, iOS icons are configured separately in export preset.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 27, 2024
@akien-mga akien-mga merged commit 1e41bf6 into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the by_extension branch August 27, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants