Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix inverted Y position description of y-sorting #93804

Conversation

AdriaandeJongh
Copy link
Contributor

Oops, my bad when I rewrote this description. Someone should have caught this ;)

Alternatively, I could change this to nodes with a higher Y position (lower on the screen) or nodes with a higher Y position (which is down in world space) to avoid confusion about world space and screen space.

@AdriaandeJongh AdriaandeJongh requested a review from a team as a code owner July 1, 2024 09:19
@AThousandShips AThousandShips changed the title [Doc] Fixed inverted Y position description of y-sorting [Doc] Fix inverted Y position description of y-sorting Jul 1, 2024
@AThousandShips AThousandShips added bug documentation cherrypick:4.1 cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 1, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 1, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've been ME

I need to rebase #93735 again now.

It's okay to come up with different wording another time, it's important to fix inaccuracies first.

@AdriaandeJongh
Copy link
Contributor Author

FYI: I rewrote the Y-sorting description in #90096, which wasn't in 4.2 or 4.1, so cherrypicks for those branches might not apply.

@Mickeon
Copy link
Contributor

Mickeon commented Jul 1, 2024

Then those two are worth cherry-picking too, and then followed by this.

@akien-mga akien-mga merged commit 09f4dff into godotengine:master Jul 1, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@AdriaandeJongh AdriaandeJongh deleted the y-sorting-lower-higher-inverted-fix branch July 1, 2024 18:33
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants