Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the visibility for the custom templates for all platforms #93867

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jul 2, 2024

Hide the custom template options behind the Advanced Options toggle

@dsnopek
Copy link
Contributor

dsnopek commented Jul 11, 2024

I think this is overall a good change. The custom templates have been the first thing on all export presets, but it's not a feature most developers use, so making it an "Advanced" setting makes sense.

The main downside in my mind, is that this will probably be a surprising change, since these options have been first for so long and everyone is used to mentally skipping over them. :-) It would also be nice for Godot 4.4 to move more options to "Advanced" on all the platforms, so folks can really see the advantage of having a cleaned up export preset form, rather than just a surprising hiding of the first two fields.

@akien-mga
Copy link
Member

akien-mga commented Sep 4, 2024

It would also be nice for Godot 4.4 to move more options to "Advanced" on all the platforms, so folks can really see the advantage of having a cleaned up export preset form, rather than just a surprising hiding of the first two fields.

Yeah I agree with this. I think it can be valuable to have this split between basic/advanced options, but if this only affects the custom templates (which are still a fairly commonly used feature, compared to a lot of the more niche options some exporters have), users might fail to see why it's a good change.

So it could be worth doing a first pass at reviewing which fields could be made "advanced" options in each exporter.

CC @bruvzg @adamscott

@bruvzg
Copy link
Member

bruvzg commented Sep 4, 2024

So it could be worth doing a first pass at reviewing which fields could be made "advanced" options in each exporter.

There are a bunch of settings that are likely rarely changed, and can be in "advanced":

  • iOS:
    • application/additional_plist_content
    • application/delete_old_export_files_unconditionally
    • application/generate_simulator_library_if_missing
    • application/icon_interpolation
    • application/signature
  • macOS:
    • application/additional_plist_content
    • application/export_angle
    • application/icon_interpolation
    • application/signature
    • display/high_res
    • xcode/platform_build
    • xcode/sdk_build
    • xcode/sdk_name
    • xcode/sdk_version
    • xcode/xcode_build
    • xcode/xcode_version
  • Windows:
    • application/d3d12_agility_sdk_multiarch
    • application/export_angle
    • application/export_d3d12
    • application/icon_interpolation

Currently, only privacy manifest settings for macOS/iOS are in Advacned.

@m4gr3d m4gr3d force-pushed the move_custom_templates_in_advanced_options branch from dbc5b2e to c45f049 Compare December 17, 2024 20:53
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Dec 17, 2024

So it could be worth doing a first pass at reviewing which fields could be made "advanced" options in each exporter.

There are a bunch of settings that are likely rarely changed, and can be in "advanced":

  • iOS:

    • application/additional_plist_content
    • application/delete_old_export_files_unconditionally
    • application/generate_simulator_library_if_missing
    • application/icon_interpolation
    • application/signature
  • macOS:

    • application/additional_plist_content
    • application/export_angle
    • application/icon_interpolation
    • application/signature
    • display/high_res
    • xcode/platform_build
    • xcode/sdk_build
    • xcode/sdk_name
    • xcode/sdk_version
    • xcode/xcode_build
    • xcode/xcode_version
  • Windows:

    • application/d3d12_agility_sdk_multiarch
    • application/export_angle
    • application/export_d3d12
    • application/icon_interpolation

Currently, only privacy manifest settings for macOS/iOS are in Advacned.

@bruvzg I moved the settings you listed under Advanced.

Hide the custom template options behind the `Advanced Options` toggle
@m4gr3d m4gr3d force-pushed the move_custom_templates_in_advanced_options branch from c45f049 to 2d3f696 Compare December 17, 2024 21:08
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akien-mga akien-mga merged commit 6244d8f into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the move_custom_templates_in_advanced_options branch December 18, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants