Add icon for local variable completion options #94196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolonProduction
force-pushed
the
local-var-icon
branch
2 times, most recently
from
aa0d484 to
5e6b2d4
Compare
|
This is a good change, but I'm not sure this icon is the best option. Personally, I associate brackets with packed arrays: |
|
This makes sense to me, but I'd use a different icon as @dalexeev mentioned. I can't find the |
|
Can't find it as well, must have misremembered that. I adjusted your icon to be 16x16 (the completion icons don't preserve aspect ratio): Looks good to me. |
HolonProduction
force-pushed
the
local-var-icon
branch
2 times, most recently
from
be47d89 to
d128c83
Compare
HolonProduction
force-pushed
the
local-var-icon
branch
from
d128c83 to
5c9d805
Compare
dalexeev
approved these changes
Jan 12, 2025
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #92566
Local variables used the
Varianticon till now, which spells out "any"(I think in 3.x it spelled out "var" which made more sense for those options).I guess I misremembered that.Users could wrongly believe the icon has something to do with the detected type, therefore this PR introduces a new icon:
The icon is inspired by VSCodes Icon for local variables:
