GDShader: Add hint_enum
for uniform int
#94198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new shader uniform hint for
int
namedhint_enum
.Similar to
@export_enum
, this changes theint
input into a dropdown in the editor.This has been requested in #8738 and then later in godot-proposals #7847
Unresolved Issues
There are two unresolved aspects to this PR:
.gdshader
parser, and maybe the error handling could be better? At the moment, using strings outside of this hint results in something like:Expected expression, found 'STRING_CONSTANT'
. Maybe it should be something more coherent, like:Strings are not supported in shaders.
?PackedStringArray
andString
inputs. I wasn't able to figure out how to fix this.