Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
insane_particle_unification_
branch
2 times, most recently
from
f69f01a to
6c4336f
Compare
KoBeWi
commented
Jul 21, 2024
| @@ -1465,6 +1465,7 @@ void CPUParticles3D::_bind_methods() { | |||
| ClassDB::bind_method(D_METHOD("get_mesh"), &CPUParticles3D::get_mesh); | |||
|
|
|||
| ClassDB::bind_method(D_METHOD("restart"), &CPUParticles3D::restart); | |||
| ClassDB::bind_method(D_METHOD("capture_aabb"), &CPUParticles3D::capture_aabb); | |||
There was a problem hiding this comment.
For some reason CPU particles did not expose this method, while GPU did.
I needed it to generate AABB.
There was a problem hiding this comment.
But what about the 2D equivalent?
There was a problem hiding this comment.
Only GPU particles allow generating rect, so the code could handle a specific class. In 3D, since both types can generate AABB, I just used call().
There was a problem hiding this comment.
Okay then. If I could choose I'd rather have this exposed in another PR to keep it clean but it's also not that big of a deal.
KoBeWi
force-pushed
the
insane_particle_unification_
branch
3 times, most recently
from
0b15aec to
28f8738
Compare
QbieShay
reviewed
Aug 8, 2024
KoBeWi
force-pushed
the
insane_particle_unification_
branch
from
28f8738 to
b00a7b0
Compare
akien-mga
approved these changes
Oct 4, 2024
KoBeWi
force-pushed
the
insane_particle_unification_
branch
from
b00a7b0 to
a4d724b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies all particle editors to use single base class and remove code duplication.