Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to enable use of accurate path tangents for polygon rotation in CSGPolygon3D #94479

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add flag to enable use of accurate path tangents for polygon rotation in CSGPolygon3D #94479

merged 1 commit into from
Jan 20, 2025

Conversation

juanjp600
Copy link
Contributor

Fixes #94417.

@juanjp600 juanjp600 requested a review from a team as a code owner July 17, 2024 18:25
@AThousandShips AThousandShips added this to the 4.4 milestone Jul 17, 2024
@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch 2 times, most recently from 83fdbc5 to bfbade0 Compare July 26, 2024 15:06
@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch 3 times, most recently from 32365b2 to 5b8c0ae Compare July 26, 2024 15:47
Calinou
Calinou reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

csg_accurate.mp4

@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch 2 times, most recently from 0419003 to be2d29e Compare July 30, 2024 17:49
@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch from be2d29e to 9473e27 Compare September 22, 2024 17:15
@fire
Copy link
Member

fire commented Nov 30, 2024

I like the feature and would try to find time to review it.

@akien-mga akien-mga requested a review from Calinou January 17, 2025 08:47
@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch from 9473e27 to d97ec01 Compare January 17, 2025 11:15
@juanjp600 juanjp600 requested a review from a team as a code owner January 17, 2025 11:15
@juanjp600
Add flag to enable use of accurate path tangents for polygon rotation…
dd7bbcc 
… in `CSGPolygon3D`

The new property is called `path_rotation_accurate`.
@juanjp600 juanjp600 force-pushed the opt-in-path-rotation-tangent-fix branch from d97ec01 to dd7bbcc Compare January 17, 2025 11:18
Calinou
Calinou approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and docs look good to me.

@Repiteo Repiteo merged commit d9d705d into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks!

@juanjp600 juanjp600 deleted the opt-in-path-rotation-tangent-fix branch January 21, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@fire fire fire approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

CSGPolygon3D's ends in path mode are oriented incorrectly
5 participants
@juanjp600 @fire @Repiteo @Calinou @AThousandShips