Make "Remove Item" appear at the top of the list when editing the value of an array or dictionary #94522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exciting, this always bugged me. Great change. Hope this merged, looks good and makes sense to me. 🕺 🥳 |
…iting the type of value in an array or dictionary
RoyBerardo
force-pushed
the
move-array-dict-remove-item
branch
from
c344dff to
2984323
Compare
Mickeon
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Not against this, actually. Due of all Variants being allowed, there's no real "most common option" that could be argued should appear at the top. Makes removing items a breeze, too.
Only concern is how this PR will interact with #78656.
akien-mga
approved these changes
Aug 28, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the "Remove Item" option to the top of the list when editing an array/dict value, as opposed to the bottom:
Just a small QOL thing that I think is nice