[Windows/Linux] Check custom export templates architecture. #94588
+157
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
check_custom_templ_arch
branch
from
39fac8e to
2a61451
Compare
akien-mga
approved these changes
Aug 16, 2024
AThousandShips
approved these changes
Aug 16, 2024
bruvzg
force-pushed
the
check_custom_templ_arch
branch
from
2a61451 to
f72e74f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to ensure custom export template binary architecture is matching one selected in the export settings.
GDExtension and .NET export rely on
binary_format/architecturevalue during export, and it's easy to select wrong binary as custom export template or forgot to changearchitecturein the export settings and get unusable export.