C#: Fix GD0107 not applying to arrays and dictionaries containing nodes

[juanjp600]

Fixes #94589.

[raulsntos]

Thanks for contributing to the .NET module! This makes sense to me, and GDScript already reports an error for exported Array[Node] variables.

This PR currently only applies to Node[] but the diagnostic should also be reported for Godot.Collections.Array<Node>.

Also, since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.

Feel free to reach out in the development chat if you need help.

[juanjp600]

Nice catch, thanks! I've added checks for Godot.Collection.Array<T> and Godot.Collections.Dictionary<TKey, TValue>.

Here's a new resource class to test with:

using Godot;
using System;

[GlobalClass]
public partial class AResource : Resource
{
	[Export] public ANode3D[] DotnetArrayField;
	[Export] public Godot.Collections.Array<ANode3D> GodotArrayField;
	[Export] public Godot.Collections.Dictionary<ANode3D, string> GodotDictionaryWithNodeAsKeyField;
	[Export] public Godot.Collections.Dictionary<string, ANode3D> GodotDictionaryWithNodeAsValueField;
	
	[Export] public ANode3D[] DotnetArrayProperty { get; set; }
	[Export] public Godot.Collections.Array<ANode3D> GodotArrayProperty { get; set; }
	[Export] public Godot.Collections.Dictionary<ANode3D, string> GodotDictionaryWithNodeAsKeyProperty { get; set; }
	[Export] public Godot.Collections.Dictionary<string, ANode3D> GodotDictionaryWithNodeAsValueProperty { get; set; }
}

[raulsntos]

You'll also need to add tests for the new cases that are expected to report the diagnostic in the ExportDiagnostics_GD0107.cs file.

The C# you just shared is pretty close, just need to add {|GD0107:Identifier|} in the places were the GD0107 diagnostic is expected.

[raulsntos]

Looks good to me, thanks!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 4.3.1.