[Font Import] Detect pixel fonts and disable subpixel positioning. #94609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
reviewed
Jul 22, 2024
bruvzg
force-pushed
the
pixel_font_detect
branch
from
b354f8c to
719e699
Compare
Calinou
reviewed
Jul 22, 2024
Calinou
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
Testing project: test_pr_94609.zip
Fonts detected as pixel art within the project:
| Font file | Is pixel art? |
|---|---|
| bedstead-condensed | Non-pixel |
| bedstead-extended | Non-pixel |
| bedstead-extracondensed | Non-pixel |
| bedstead-semicondensed | Non-pixel |
| bedstead-ultracondensed | Non-pixel |
| CommitMono-400-Italic | Non-pixel |
| CommitMono-400-Regular | Non-pixel |
| CommitMono-700-Italic | Non-pixel |
| CommitMono-700-Regular | Non-pixel |
| Kenney Pixel Square | Pixel |
| Kenney Pixel | Pixel |
| PixelOperator | Pixel |
| PixelOperator-Bold | Pixel |
| PixelOperator8 | Pixel |
| PixelOperator8-Bold | Pixel |
| PixelOperatorHB | Pixel |
| PixelOperatorHB8 | Pixel |
| PixelOperatorHBSC | Pixel |
| PixelOperatorMono | Pixel |
| PixelOperatorMono-Bold | Pixel |
| PixelOperatorMono8 | Pixel |
| PixelOperatorMono8-Bold | Pixel |
| PixelOperatorMonoHB | Pixel |
| PixelOperatorMonoHB8 | Pixel |
| PixelOperatorSC | Pixel |
| PixelOperatorSC-Bold | Pixel |
| TerminusTTF-4.49.3 | Pixel |
| TerminusTTF-Bold-4.49.3 | Pixel |
| TerminusTTF-Bold-Italic-4.49.3 | Pixel |
| TerminusTTF-Italic-4.49.3 | Pixel |
| spleen-12x24 | Pixel |
| spleen-16x32 | Pixel |
| spleen-32x64 | Pixel |
| spleen-6x12 | Pixel |
| spleen-8x16 | Pixel |
| terminal-grotesque | Pixel |
All detections are OK.
Calinou
reviewed
Jul 23, 2024
bruvzg
force-pushed
the
pixel_font_detect
branch
from
719e699 to
32bc1c2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent issues like #94591 (and previous similar issues).
There's no 100% reliable way to detect pixel fonts, this PR checks if every glyph contours contain only straight horizontal and vertical lines in attempt to detect it.