Avoid potential crash on signal disconnection #94666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you forgot to include some files |
RandomShaper
force-pushed
the
fix_tangled_obj_clear_crash
branch
from
db3db40 to
2326329
Compare
|
You're right. Fixed. |
RandomShaper
force-pushed
the
fix_tangled_obj_clear_crash
branch
from
2326329 to
fb76ba6
Compare
akien-mga
reviewed
Jul 23, 2024
RandomShaper
force-pushed
the
fix_tangled_obj_clear_crash
branch
from
fb76ba6 to
100935e
Compare
RandomShaper
added
the
cherrypick:4.3
RandomShaper
force-pushed
the
fix_tangled_obj_clear_crash
branch
from
100935e to
32b7f83
Compare
akien-mga
approved these changes
Aug 19, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not been able to come up with an MRP. It seems that on very complex resource dependency graphs, with signal connections among them, there's the possibility of hitting a pathological case where a signal connection is no longer in the map, which causes as segfault.