Make primitive meshes react to texel size change #94726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
enhancement
topic:3d
cherrypick:4.3
BastiaanOlij
force-pushed
the
primitive_texel_size_update
branch
from
b2974c5 to
471443e
Compare
BastiaanOlij
force-pushed
the
primitive_texel_size_update
branch
from
471443e to
b302e52
Compare
Calinou
reviewed
Jul 25, 2024
clayjohn
reviewed
Jul 25, 2024
BastiaanOlij
force-pushed
the
primitive_texel_size_update
branch
from
b302e52 to
b9790ce
Compare
Calinou
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
change_primitive_size_project_setting.mp4
I've also opened a proposal which relates to this PR a bit: godotengine/godot-proposals#10311
clayjohn
removed
the
cherrypick:4.3
clayjohn
approved these changes
Aug 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes primitive meshes subscribe to project settings changes so that we rebuild the mesh if the texel size changes.
Fixes #94637