Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12: Be explicit about all-resources texture barriers #94733

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

RandomShaper
Copy link
Member

This helps D3D12 implementations that would think any subresource specification other than the special "all resources" value comprises only a subset of those, regardless the detailed specification does cover all of them.

@RandomShaper RandomShaper added this to the 4.3 milestone Jul 25, 2024
@RandomShaper RandomShaper requested a review from DarioSamo July 25, 2024 11:10
@RandomShaper RandomShaper requested a review from a team as a code owner July 25, 2024 11:10
@RandomShaper RandomShaper modified the milestones: 4.3, 4.4 Jul 25, 2024
@RandomShaper RandomShaper added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 25, 2024
@RandomShaper RandomShaper force-pushed the d3d12_tex_barr_fast branch from 9dff0db to 3260437 Compare July 25, 2024 13:06
Copy link
Contributor

@DarioSamo DarioSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, it'd just be nice to have the comment about the specification quirk regarding the all subresources value stated directly in the code itself.

@DarioSamo
Copy link
Contributor

Comment was added, approved.

@akien-mga akien-mga merged commit 1fea6ed into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the d3d12_tex_barr_fast branch August 16, 2024 15:46
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants