Add validation to glTF importer for Blendshape and Animation #94783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
reviewed
Jul 26, 2024
TokageItLab
force-pushed
the
validate-gltf-anim-name
branch
from
5c0393a to
b9845a8
Compare
TokageItLab
force-pushed
the
validate-gltf-anim-name
branch
from
b9845a8 to
0235086
Compare
akien-mga
requested review from
adamscott and
aaronfranke
and removed request for
adamscott
aaronfranke
approved these changes
Sep 6, 2024
|
May have to do to the fbx importer too |
@TokageItLab Could you assess this? |
|
Confirmed that fix is valid with fbx as well.
|
fire
approved these changes
Sep 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if there are other places where this is needed, but these related to animation need to be validated as they can break the Track path.
I am not sure if this needs to be punt to 4.4, as it breaks compatibility but is an invalid property name to begin with;
:is used by type annotation and subpath.