Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove unused PoolAllocator #94792

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

akien-mga
Copy link
Member

It was used in 3.x for PoolVector types, but it's not used anymore since 4.0.

If some downstream forks or C++ modules were making use of it, they can still copy the file in their fork/module to keep using it.

@akien-mga akien-mga added this to the 4.4 milestone Jul 26, 2024
@akien-mga akien-mga requested a review from a team as a code owner July 26, 2024 11:07
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, internal and unused

@alvinhochun
Copy link
Contributor

alvinhochun commented Jul 27, 2024

@AThousandShips
Copy link
Member

This is about PoolAllocator not PoolVector, that type doesn't exist any longer, that page needs a significant update but it's unrelated to this PR

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds and tests passed. Looks good to me.

@akien-mga akien-mga merged commit 56ffcab into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga akien-mga deleted the core-remove-poolallocator branch August 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants