-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Add sanitizers for llvm-mingw, increase stack for ASan #94845
Windows: Add sanitizers for llvm-mingw, increase stack for ASan #94845
Conversation
ASan and UBSan are supported by llvm-mingw. They can be enabled by passing `use_asan=yes use_ubsan=yes` to scons.
71e83fa
to
0cda0b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if README is up-to-date, but seems like sanitizers have some limitations:
- Address Sanitizer doesn't produce working backtraces for i686.
- The sanitizers are only supported on x86.
So we probably should have env["arch"]
checks when enabling it.
Backtraces do work for i686, I've used it before. The readme is a bit outdated on this. The sanitizers are indeed not yet working on arm32/aarch64 according to the maintainer (UBSan might work but it's not enabled for aarch64 in the build) so I suppose I can add a check for it. If they ever gets fixed we can remove the check in the future. |
Thanks! |
Due to this PR, the build command no longer works. Is something wrong with sanitization? |
ASan and UBSan are supported by llvm-mingw. They can be enabled by passing
use_asan=yes use_ubsan=yes
to scons.