Fix custom resources using incorrect icons #94854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.2
KoBeWi
approved these changes
Aug 13, 2024
|
Needs to be squashed into one commit. |
This comment was marked as resolved.
This comment was marked as resolved.
ianmccleary
force-pushed
the
custom-resource-icon-fix
branch
from
8b78db9 to
5b1f3ec
Compare
ianmccleary
force-pushed
the
custom-resource-icon-fix
branch
from
5b1f3ec to
140f9dc
Compare
|
Commits squashed, should be good to go. Let me know if anything else needs to be done 😄 |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #93874
Fix #92942
Instead of going by the first dependency, go by the icon linked to the resource's script class (if it has one)
I'm unsure if the rest of the function is necessary (or what cases it covers really) but I chose to leave it in for safety's sake. I'm not familiar enough with the code base to make that assumption confidently.
Please let me know if there's anything I missed or failed to consider!