Add missing CallableCustomMethodPointer for const methods #94864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rune-scape
force-pushed
the
add-missing-method-bind
branch
from
440f1ea to
fd819dd
Compare
rune-scape
force-pushed
the
add-missing-method-bind
branch
from
fd819dd to
a84c480
Compare
KoBeWi
approved these changes
Sep 25, 2024
Seems like |
|
The fact that language features are modeled as items in the standard library makes that non-avoidable in cases like this. |
|
Thanks! |
akien-mga
added
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually slightly refactored the code to reduce duplicate code and to allow const functions returning void
and fixed some incorrect functions in
binder_common.hrequired for #94744