Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScriptParser: Avoid const_cast of AnnotationNode #94888

Merged

Conversation

rune-scape
Copy link
Contributor

removes the const_cast in GDScriptParser by changing the definition of AnnotationActions first param to a mutable pointer

Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga changed the title GDScriptParser: Avoid const_cast GDScriptParser: Avoid const_cast Aug 27, 2024
@akien-mga akien-mga changed the title GDScriptParser: Avoid const_cast GDScriptParser: Avoid const_cast of AnnotationNode Aug 27, 2024
@akien-mga akien-mga changed the title GDScriptParser: Avoid const_cast of AnnotationNode GDScriptParser: Avoid const_cast of AnnotationNode Aug 27, 2024
@akien-mga akien-mga merged commit 6eb1d3c into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@rune-scape rune-scape deleted the no-const-cast-gdscript-parser branch August 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants