Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uniform subgroup in shader will carry out to next group #94896

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix uniform subgroup in shader will carry out to next group #94896

merged 1 commit into from
Aug 16, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #94877

@jsjtxietian jsjtxietian requested a review from a team as a code owner July 29, 2024 03:07
@AThousandShips AThousandShips added bug topic:shaders cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 29, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Jul 29, 2024
@akien-mga akien-mga requested a review from a team July 29, 2024 09:52
Chaosus
Chaosus approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@Chaosus Chaosus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 5098ac5 into godotengine:master Aug 16, 2024
18 checks passed
@jsjtxietian jsjtxietian deleted the carry-subgroup branch August 16, 2024 08:48
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Uniform subgroup in shader carries out to next group
4 participants
@jsjtxietian @akien-mga @Chaosus @AThousandShips