Report shader arrays sized after spec constants as zero-sized #94985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
enhancement
topic:rendering
cherrypick:4.2
RandomShaper
force-pushed
the
sc_sized_array
branch
from
d6982b3 to
30b48dc
Compare
clayjohn
reviewed
Jul 31, 2024
thirdparty/spirv-reflect/patches/2-zero-size-for-sc-sized-arrays.patch
Outdated
Show resolved
Hide resolved
This effectively disables validation of the size of the data provided.
RandomShaper
force-pushed
the
sc_sized_array
branch
from
30b48dc to
90679f1
Compare
clayjohn
approved these changes
Jul 31, 2024
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively disables validation of the size of the data provided.
Fixes #94881.