Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTF: Propagate owner for root node children #95121

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Aug 4, 2024

I ran into an edge case where this code designed to propagate the owner for all generated nodes:

Array args;
args.append(p_scene_root);
current_node->propagate_call(StringName("set_owner"), args);

was not being run for the special case of the root node itself. Therefore, if an extension tried to generate multiple nodes for one glTF node, this would fail if that node was the root node.

I used unlikely here because this won't be the case for most files, and it will happen at most once per file.

This is a fairly straightforward change, we could merge it before 4.3, but I put it as 4.4+cherrypick because we are very close to release and this bugfix is very non-critical.

@aaronfranke aaronfranke added bug topic:import topic:3d cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 4, 2024
@aaronfranke aaronfranke added this to the 4.4 milestone Aug 4, 2024
@aaronfranke aaronfranke requested a review from a team as a code owner August 4, 2024 09:33
@akien-mga akien-mga merged commit 3e1b61d into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the gltf-root-prop-owner branch August 19, 2024 20:24
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants