GLTF: Propagate owner for root node children #95121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an edge case where this code designed to propagate the owner for all generated nodes:
was not being run for the special case of the root node itself. Therefore, if an extension tried to generate multiple nodes for one glTF node, this would fail if that node was the root node.
I used
unlikely
here because this won't be the case for most files, and it will happen at most once per file.This is a fairly straightforward change, we could merge it before 4.3, but I put it as 4.4+cherrypick because we are very close to release and this bugfix is very non-critical.